[PATCH] netfilter: seqadj: check seq offset before update

From: zhang kai
Date: Thu Dec 23 2021 - 22:14:15 EST


if seq/ack offset is zero, don't update

Signed-off-by: zhang kai <zhangkaiheb@xxxxxxx>
---
net/netfilter/nf_conntrack_seqadj.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/net/netfilter/nf_conntrack_seqadj.c b/net/netfilter/nf_conntrack_seqadj.c
index 3066449f8bd8..d35e272a2e36 100644
--- a/net/netfilter/nf_conntrack_seqadj.c
+++ b/net/netfilter/nf_conntrack_seqadj.c
@@ -186,11 +186,13 @@ int nf_ct_seq_adjust(struct sk_buff *skb,
else
seqoff = this_way->offset_before;

- newseq = htonl(ntohl(tcph->seq) + seqoff);
- inet_proto_csum_replace4(&tcph->check, skb, tcph->seq, newseq, false);
- pr_debug("Adjusting sequence number from %u->%u\n",
- ntohl(tcph->seq), ntohl(newseq));
- tcph->seq = newseq;
+ if (seqoff) {
+ newseq = htonl(ntohl(tcph->seq) + seqoff);
+ inet_proto_csum_replace4(&tcph->check, skb, tcph->seq, newseq, false);
+ pr_debug("Adjusting sequence number from %u->%u\n",
+ ntohl(tcph->seq), ntohl(newseq));
+ tcph->seq = newseq;
+ }

if (!tcph->ack)
goto out;
@@ -201,6 +203,9 @@ int nf_ct_seq_adjust(struct sk_buff *skb,
else
ackoff = other_way->offset_before;

+ if (!ackoff)
+ goto out;
+
newack = htonl(ntohl(tcph->ack_seq) - ackoff);
inet_proto_csum_replace4(&tcph->check, skb, tcph->ack_seq, newack,
false);
--
2.17.1