Re: [PATCH v3 1/4] Input: Add driver for Cypress Generation 5 touchscreen

From: Andy Shevchenko
Date: Thu Dec 23 2021 - 08:52:02 EST


On Mon, Dec 6, 2021 at 9:05 AM Alistair Francis <alistair@xxxxxxxxxxxxx> wrote:
>
> From: Mylène Josserand <mylene.josserand@xxxxxxxxxxx>
>
> This is the basic driver for the Cypress TrueTouch Gen5 touchscreen
> controllers. This driver supports only the I2C bus but it uses regmap
> so SPI support could be added later.
> The touchscreen can retrieve some defined zone that are handled as
> buttons (according to the hardware). That is why it handles
> button and multitouch events.

Most of the comments I just gave against v2 are applicable here,
please address them.

--
With Best Regards,
Andy Shevchenko