Re: [PATCH v1 1/1] serial: 8250_exar: derive nr_ports from ID for Acces I/O cards

From: Andy Shevchenko
Date: Thu Dec 23 2021 - 05:19:45 EST


On Thu, Dec 23, 2021 at 12:05:11PM +0200, Ilpo Järvinen wrote:
> On Wed, 22 Dec 2021, Andy Shevchenko wrote:

...

> > - nr_ports = board->num_ports ? board->num_ports : pcidev->device & 0x0f;
> > + if (pcidev->vendor == PCI_VENDOR_ID_ACCESSIO)
> > + nr = BIT(((pcidev->device & 0x38) >> 3) - 1);
>
> Shouldn't this be nr_ports = ...

Yeah, sorry for that. By some reason I have no such config option enabled and
my builds haven't failed.

--
With Best Regards,
Andy Shevchenko