Re: [PATCH 0/6] x86/insn: Add instructions to instruction decoder

[Masami Hiramatsu]

Hi,

Sorry, I missed this series.

On Thu,  2 Dec 2021 11:50:23 +0200
Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:

> Hi
> 
> Here are patches to bring the kernel and tools x86 instruction decoder
> more up to date.
> 
> x86 instruction decoder is used for both kernel instructions and user space
> instructions (e.g. uprobes, perf tools Intel PT), so it is good to update
> it with new instructions.

Hmm, I thought perf used objdump for that purpose internally.
Anyway, this series looks good to me. I'm a bit surprised that the
insn decoder can actually support those instructions only changing
X86_EVEX_M() macro :-)

Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thank you!

> 
> 
> Adrian Hunter (6):
>       perf tests: Add AMX instructions to x86 instruction decoder test
>       x86/insn: Add AMX instructions to x86 instruction decoder
>       perf tests: Add misc instructions to x86 instruction decoder test
>       x86/insn: Add misc instructions to x86 instruction decoder
>       perf tests: Add AVX512-FP16 instructions to x86 instruction decoder test
>       x86/insn: Add AVX512-FP16 instructions to x86 instruction decoder
> 
>  arch/x86/include/asm/insn.h                  |    2 +-
>  arch/x86/lib/x86-opcode-map.txt              |  111 +-
>  tools/arch/x86/include/asm/insn.h            |    2 +-
>  tools/arch/x86/lib/x86-opcode-map.txt        |  111 +-
>  tools/perf/arch/x86/tests/insn-x86-dat-32.c  |  918 +++++++++++++++++
>  tools/perf/arch/x86/tests/insn-x86-dat-64.c  | 1426 ++++++++++++++++++++++++++
>  tools/perf/arch/x86/tests/insn-x86-dat-src.c | 1189 +++++++++++++++++++++
>  7 files changed, 3731 insertions(+), 28 deletions(-)
> 
> 
> Regards
> Adrian


-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>