Re: [PATCH] scsi: bsg: Ignore bsg queue registration failures again

From: Christoph Hellwig
Date: Thu Dec 23 2021 - 01:35:01 EST


On Wed, Dec 22, 2021 at 08:54:27AM -0800, Guenter Roeck wrote:
> Since commit 5f7cf82c1d73 ("scsi: bsg: Fix errno when
> scsi_bsg_register_queue() fails"), errors from registering the bsg queue
> are no longer ignored but returned to the caller. At the same time, the
> comment in the code still states that errors are ignored. On top of that,
> the message preporting the problem is printed as dev_info, not dev_err.
> Both suggest that errors from bsg queue registrations should indeed be
> ignored.

But there is no good reason to ignore it. The proper fix is to fully
handle the errors.