Re: [PATCH 02/16] dt-bindings: arm: renesas: Document SMARC EVK

From: Lad, Prabhakar
Date: Wed Dec 22 2021 - 14:37:56 EST


Hi Rob,

Thank you for the review.

On Wed, Dec 22, 2021 at 6:23 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Tue, Dec 21, 2021 at 09:47:03AM +0000, Lad Prabhakar wrote:
> > From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> >
> > Document Renesas SMARC EVK board which is based on RZ/V2L (R9A07G054)
> > SoC. The SMARC EVK consists of RZ/V2L SoM module and SMARC carrier board,
> > the SoM module sits on top of the carrier board.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/arm/renesas.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> > index 55a5aec418ab..fa435d6fda77 100644
> > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > @@ -423,6 +423,8 @@ properties:
> >
> > - description: RZ/V2L (R9A07G054)
> > items:
> > + - enum:
> > + - renesas,smarc-evk # SMARC EVK
>
> This and patch 1 should be combined. Changing the number of compatible
> entries doesn't make sense.
>
Will merge this with patch 1. Is it OK if I include your Ack when merged?

Cheers,
Prabhakar

> > - enum:
> > - renesas,r9a07g054l1 # Single Cortex-A55 RZ/V2L
> > - renesas,r9a07g054l2 # Dual Cortex-A55 RZ/V2L
> > --
> > 2.17.1
> >
> >