Re: [PATCH v1 1/3] spi: dln2: Propagate firmware node

[Mark Brown]

On Wed, Dec 22, 2021 at 03:54:21PM +0200, Andy Shevchenko wrote:
> Propagate firmware node by using a specific API call, i.e. device_set_node().

This breaks at least an x86 allmodconfig build:

/mnt/kernel/drivers/spi/spi-dln2.c: In function 'dln2_spi_probe':
/mnt/kernel/drivers/spi/spi-dln2.c:691:32: error: implicit declaration of function 'dev_fwnode'; did you mean 'dev_of_node'? [-Werror=implicit-function-declaration]
  691 |  device_set_node(&master->dev, dev_fwnode(dev));
      |                                ^~~~~~~~~~
      |                                dev_of_node
/mnt/kernel/drivers/spi/spi-dln2.c:691:32: error: passing argument 2 of 'device_set_node' makes pointer from integer without a cast [-Werror=int-conversion]
  691 |  device_set_node(&master->dev, dev_fwnode(dev));
      |                                ^~~~~~~~~~~~~~~
      |                                |
      |                                int
In file included from /mnt/kernel/include/linux/platform_device.h:13,
                 from /mnt/kernel/drivers/spi/spi-dln2.c:10:
/mnt/kernel/include/linux/device.h:854:64: note: expected 'struct fwnode_handle *' but argument is of type 'int'
  854 | void device_set_node(struct device *dev, struct fwnode_handle *fwnode);
      |                                          ~~~~~~~~~~~~~~~~~~~~~~^~~~~~
cc1: all warnings being treated as errors

Attachment: signature.asc
Description: PGP signature