Re: [PATCH v2 08/13] KVM: selftests: add SEV boot tests

[Paolo Bonzini]

On 12/21/21 16:40, Michael Roth wrote:
> > Probably, you want to use macros to represent those states which should
> > make it more clear. Otherwise, it is quite cumbersome for readers to
> > remember the meaning (or state) of 100/101/102.
> I agree with that approach in general, but in this case it's a bit
> awkward since, these aren't necessarily similarly grouped tests where each
> test falls under a certain category of TEST_GROUP_x where a macro would
> provide additional information about the nature of the tests related to a
> particular SYNC() call, in some cases it's an aggregate of multiple
> things, for instance...

Indeed, these are just numbers that match between guest_test_common and 
test_common.  It's not too hard to follow if you look at the two 
functions side-by-side.

Paolo