Re: [PATCH] ath10k: replace strlcpy with strscpy

From: Kalle Valo
Date: Wed Dec 22 2021 - 01:02:22 EST


Jason Wang <wangborong@xxxxxxxxxx> wrote:

> The strlcpy should not be used because it doesn't limit the source
> length. So that it will lead some potential bugs.
>
> But the strscpy doesn't require reading memory from the src string
> beyond the specified "count" bytes, and since the return value is
> easier to error-check than strlcpy()'s. In addition, the implementation
> is robust to the string changing out from underneath it, unlike the
> current strlcpy() implementation.
>
> Thus, replace strlcpy with strscpy.
>
> Signed-off-by: Jason Wang <wangborong@xxxxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

9d364b828ae5 ath10k: replace strlcpy with strscpy

--
https://patchwork.kernel.org/project/linux-wireless/patch/20211221070931.725720-1-wangborong@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches