Re: [PATCH v2] memcg: add per-memcg vmalloc stat

[Muchun Song]

On Wed, Dec 22, 2021 at 1:25 PM Shakeel Butt <shakeelb@xxxxxxxxxx> wrote:
>
[...]
> @@ -2626,6 +2627,9 @@ static void __vunmap(const void *addr, int deallocate_pages)
>                 unsigned int page_order = vm_area_page_order(area);
>                 int i;
>
> +               mod_memcg_page_state(area->pages[0], MEMCG_VMALLOC,
> +                                    -(int)area->nr_pages);

The cast can go away since the type of 3rd parameter of
mod_memcg_page_state() is int but not long. I suggest
to remove it. Anyway

Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>

Thanks.