Re: [PATCH][next] kernel/sysctl.c: remove unused variable ten_thousand

From: Nick Desaulniers
Date: Tue Dec 21 2021 - 17:17:57 EST


On Tue, Dec 21, 2021 at 1:46 PM Luis Chamberlain <mcgrof@xxxxxxxxxx> wrote:
>
> On Tue, Dec 21, 2021 at 06:45:01PM +0000, Colin Ian King wrote:
> > The const variable ten_thousand is not used, it is redundant and can
> > be removed.
> >
> > Cleans up clang warning:
> > kernel/sysctl.c:99:18: warning: unused variable 'ten_thousand' [-Wunused-const-variable]
> > static const int ten_thousand = 10000;
> >
> > Fixes: c26da54dc8ca ("printk: move printk sysctl to printk/sysctl.c")
> > Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
>
> Acked-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

Just double checking; I don't think I've seen someone supply someone
else's Acked by tag in a reply before. Was there some discussion off
thread that I missed? If so, do you mind linking to it? Was this a
typo, perhaps, and you meant to supply your own Acked by tag? Are
"Luis Chamberlain" and "Andrew Morton" aliases? :^P

--
Thanks,
~Nick Desaulniers