Re: [PATCH 04/11] PCI: pci-bridge-emul: Add support for new flag PCI_BRIDGE_EMUL_NO_IO_FORWARD

From: Thomas Petazzoni
Date: Tue Dec 21 2021 - 10:42:27 EST


On Tue, 21 Dec 2021 15:14:48 +0100
Pali Rohár <pali@xxxxxxxxxx> wrote:

> Like PCI_BRIDGE_EMUL_NO_PREFMEM_FORWARD, this new flag specifies that
> emulated PCI bridge does not support forwarding of IO requests in given
> range between primary and secondary buses. This flag should be used as
> argument for pci_bridge_emul_init() for hardware setup without IO support.
>
> Setting this flag cause that IO base and limit registers are read-only.
>
> Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>

Looks good. As said on PATCH 03/11, perhaps just a snippet of
documentation in pci-bridge-emul.h to describe the semantic of the new
flag.

Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com