Re: [PATCH -next V2] sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec_minmax

From: libaokun (A)
Date: Mon Dec 20 2021 - 20:21:15 EST


在 2021/12/21 3:17, Luis Chamberlain 写道:
On Mon, Dec 20, 2021 at 05:26:27PM +0800, Baokun Li wrote:
When we pass a negative value to the proc_doulongvec_minmax() function,
the function returns 0, but the corresponding interface value does not
change.

we can easily reproduce this problem with the following commands:
`cd /proc/sys/fs/epoll`
`echo -1 > max_user_watches; echo $?; cat max_user_watches`

This function requires a non-negative number to be passed in, so when
a negative number is passed in, -EINVAL is returned.

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx>
Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

Luis
.

Thank you for your Ack.

--
With Best Regards,
Baokun Li