Re: [PATCH 2/4] staging: vc04_services: avoid the use of typedef for function pointers

[Stefan Wahren]

Am 20.12.21 um 22:29 schrieb Gaston Gonzalez:
> Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to
> better align with the linux kernel coding style.
>
> Signed-off-by: Gaston Gonzalez <gascoar@xxxxxxxxx>
> ---
>  .../vc04_services/bcm2835-camera/controls.c   | 76 +++++++++----------
>  1 file changed, 35 insertions(+), 41 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> index b096a12387f7..7782742396fc 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> @@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type {
>  	MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */
>  };
>  
> -struct bm2835_mmal_v4l2_ctrl;

Oh dear, in the whole kernel it's always bcm2835 and not bm2835. I don't
see any good reason for the different naming and the resulting confusion.

@Gaston: it's not your fault, but it would be nice to have this fixed.