Re: [PATCH 2/2] ASoC: bcm: Use platform_get_irq() to get the interrupt

From: Mark Brown
Date: Mon Dec 20 2021 - 13:30:24 EST


On Sun, Dec 19, 2021 at 06:10:39PM +0000, Lad Prabhakar wrote:
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.

This doesn't compile for at least x86_64 allmodconfig:

/mnt/kernel/sound/soc/bcm/bcm63xx-pcm-whistler.c: In function 'bcm63xx_soc_platform_probe':
/mnt/kernel/sound/soc/bcm/bcm63xx-pcm-whistler.c:395:11: error: implicit declaration of function 'irq_get_trigger_type' [-Werror=implicit-function-declaration]
395 | irq_get_trigger_type(ret), "i2s_dma", (void *)i2s_priv);
| ^~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Attachment: signature.asc
Description: PGP signature