Re: [PATCH v1 1/1] gpio: Remove unused local OF node pointers

[Andy Shevchenko]

On Mon, Dec 20, 2021 at 5:09 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
>
> On Mon, Dec 20, 2021 at 2:24 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > After the commit 448cf90513d9 ("gpio: Get rid of duplicate of_node
> > assignment in the drivers") the OF node local pointers become unused.
> > Remove them for good and make compiler happy about.
> >
> > Fixes: 448cf90513d9 ("gpio: Get rid of duplicate of_node assignment in the drivers")
> > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

...

> > -               gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
> > +               gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", np);
>
> This is unrelated though. Can you make it a separate patch?

It actually makes use of the local np IIRC.
It's related, no?

-- 
With Best Regards,
Andy Shevchenko