Re: [RFC PATCH 1/5] regmap: Add Parity bit Calculation to regmaps

[Mark Brown]

On Fri, Dec 17, 2021 at 10:41:00PM +0000, linuxkernel@xxxxxxxxxxxxxxx wrote:
> From: Christopher Tyerman <c.tyerman@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> 
> regmap.h
> 
> Added parity_read_mask to regmap_config
> Added parity_write_mask to regmap_config
> Added (*parity_calc)() to regmap_config
> 
> Added regmap_parity_calc_even() Added regmap_parity_calc_odd()
> 
> internal.h
> 
> Added parity_read_mask to regmap
> Added parity_write_mask to regmap
> Added (*parity_calc) to regmap
> 
> regmap.c
> Altered _regmap_raw_write_impl() to calculate parity
> Altered _regmap_raw_read() to calculate parity
> Added regmap_set_work_buf_parity_mask()
> Added regmap_parity_calc_even()
> Added regmap_parity_calc_odd()
> Added parity_even()
> Added parity16_even(u16 v)
> Added parity32_even(u32 v)
> Added parity64_even(u64 v)

This isn't a good changelog, the changelog needs to describe what is
being changed in the code and why in a way that provides information to
the human reader.  Instead this is essentially a list of code level
changes in the diff.  There's some advice on changelogs in
submitting-patches.rst.  Without a clear changelog it's hard to review
things as it's not clear what the goals are.

Attachment: signature.asc
Description: PGP signature