Re: linux-next: build failure after merge of the akpm tree

[Muchun Song]

On Mon, Dec 20, 2021 at 7:08 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> Hi all,
>
> After merging the akpm tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/hwmon/dell-smm-hwmon.c: In function 'i8k_ioctl':
> drivers/hwmon/dell-smm-hwmon.c:454:31: error: implicit declaration of function 'PDE_DATA'; did you mean 'NODE_DATA'? [-Werror=implicit-function-declaration]
>   454 |  struct dell_smm_data *data = PDE_DATA(file_inode(fp));
>       |                               ^~~~~~~~
>       |                               NODE_DATA
> drivers/hwmon/dell-smm-hwmon.c:454:31: error: initialization of 'struct dell_smm_data *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   2dd082773083 ("proc: remove PDE_DATA() completely")
>
> interacting with commit
>
>   073bd07205af ("hwmon: (dell-smm) Unify i8k_ioctl() and i8k_ioctl_unlocked()")
>
> from the hwmon-staging tree.
>
> I applied the following fixup patch.
>
> From: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Date: Mon, 20 Dec 2021 22:04:57 +1100
> Subject: [PATCH] fixup for "proc: remove PDE_DATA() completely"
>
> Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>

Thanks Stephen.

Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>