Re: [PATCH v2 10/17] dt-bindings: spi: add bindings for microchip mpfs spi

From: Conor.Dooley
Date: Mon Dec 20 2021 - 03:05:23 EST


On 17/12/2021 11:43, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
know the content is safe
>
> On Fri, Dec 17, 2021 at 11:40:29AM +0000, Conor.Dooley@xxxxxxxxxxxxx
wrote:
>> On 17/12/2021 11:17, Mark Brown wrote:
>>> Why do you need this property in the DT - isn't the number of chip
>>> selects in the IP a fixes property?
>>
>> Nope! It's an IP that's intended for use in FPGAs so the number of
>> selects may (and does) vary based on implementation.
>
> That doesn't explain why the number is needed in the binding - why do
> you need this property in the DT?

Took another look at the IP core configuration & I think you're right
and that property can be dropped. The register responsible for CS
control will not be optimised away even if the CS is not used & the
worst outcome is that nothing will happen.