RE: [PATCH v4 1/2] SPI: Add SPI driver for Sunplus SP7021

[Lh Kuo 郭力豪]

Hi Mr. Mark Brown

Thank you for your review.

I will fix it in the next submission

> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Saturday, December 18, 2021 1:38 AM
> To: Li-hao Kuo <lhjeff911@xxxxxxxxx>
> Cc: p.zabel@xxxxxxxxxxxxxx; andyshevchenko@xxxxxxxxx; robh+dt@xxxxxxxxxx;
> linux-spi@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Wells Lu 呂芳騰
> <wells.lu@xxxxxxxxxxx>; Lh Kuo 郭力豪 <lh.Kuo@xxxxxxxxxxx>
> Subject: Re: [PATCH v4 1/2] SPI: Add SPI driver for Sunplus SP7021
> 
> On Fri, Dec 10, 2021 at 05:02:47PM +0800, Li-hao Kuo wrote:
> 
> > +static irqreturn_t sp7021_spi_sla_irq(int irq, void *dev) {
> > +	struct sp7021_spi_ctlr *pspim = dev;
> > +	unsigned int data_status;
> > +
> > +	data_status = readl(pspim->sla_base + SP7021_DATA_RDY_REG);
> > +	writel(data_status | SP7021_SLA_CLR_INT, pspim->sla_base + SP7021_DATA_RDY_REG);
> > +	complete(&pspim->sla_isr);
> > +	return IRQ_NONE;
> > +}
> 
> This will always return IRQ_NONE even if the interrupt actually fired - that should eventually cause
> genirq to complain that there's a problem with the interrupt never being handled I think (though perhaps
> if the interrupt stops asserting it'll pick up on that).  It should return IRQ_HANDLED if there was
> something asserted in SP7021_DATA_RDY_REG.
> 
> Apart from that one thing this all looks good as far as I can see.