RE: [PATCH v2] locking/rtmutex: Fix incorrect spinning condition

From: Zhang, Qiang1
Date: Sun Dec 19 2021 - 20:46:20 EST



>Can you please fix your mail client to do proper replies without copying the mail headers into the message?

I have been fix it

>>Though this does not apply because the condition is incomplete. You
>>somehow dropped this from the condition:
>>
>> vcpu_is_preempted(task_cpu(owner)))
>>
>>Please make always sure that your patches apply against Linus tree
>>before sending them out.
>
> This commit c0bed69daf4b ("locking: Make owner_on_cpu() into
> <linux/sched.h>") make the following modifications in latest linux-next.
>
> +static inline bool owner_on_cpu(struct task_struct *owner) {
> + /*
> + * As lock holder preemption issue, we both skip spinning if
> + * task is not on cpu or its cpu is preempted
> + */
> + return owner->on_cpu && !vcpu_is_preempted(task_cpu(owner));
> +}
> +
>
>Fine, but then please tell against which tree/branch the patch is.

linux-next/master, linux-next/akpm, linux-next/akpm-base.

Thanks,

Zqiang

>
>Thanks,
>
> tglx