Re: [PATCH] 9p: fix unused-variable warning

From: David Howells
Date: Sat Dec 18 2021 - 08:52:03 EST


Dominique Martinet <asmadeus@xxxxxxxxxxxxx> wrote:

> David since then fixed the warning differently in v2 of the patch (he
> moved the fscache_note_page_release() out of the ifdef), so I won't do
> anything with this even if in principle I tend to agree that
> if(IS_ENABLED()) lead to better compiler coverage

Yeah, fscache_note_page_release() compiles out in such a case because
v9fs_inode_cookie() becomes unconditionally NULL if it's disabled.

If you want me to do something different, can you give me an incremental patch
to merge into mine?

David