Re: [PATCH] qlcnic: potential dereference null pointer of rx_queue->page_ring

From: patchwork-bot+netdevbpf
Date: Sat Dec 18 2021 - 07:40:32 EST


Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@xxxxxxxxxxxxx>:

On Fri, 17 Dec 2021 17:39:11 +0800 you wrote:
> The return value of kcalloc() needs to be checked.
> To avoid dereference of null pointer in case of the failure of alloc.
> Therefore, it might be better to change the return type of
> qlcnic_sriov_alloc_vlans() and return -ENOMEM when alloc fails and
> return 0 the others.
> Also, qlcnic_sriov_set_guest_vlan_mode() and __qlcnic_pci_sriov_enable()
> should deal with the return value of qlcnic_sriov_alloc_vlans().
>
> [...]

Here is the summary with links:
- qlcnic: potential dereference null pointer of rx_queue->page_ring
https://git.kernel.org/netdev/net/c/60ec7fcfe768

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html