Re: [PATCH v2] mfd: rk808: add reboot support to rk808.c

From: Dmitry Osipenko
Date: Fri Dec 17 2021 - 13:30:09 EST


17.12.2021 21:16, Peter Geis пишет:
>>> + break;
>>> + default:
>>> + dev_info(&client->dev, "pmic controlled board reset not supported\n");

I'd change this dev_info to dev_dbg to not clutter KMSG.

>> I'd set ret=0 explicitly here. Later on somebody may change the code and
>> ret won't be zero anymore, this is not an uncommon trouble in kernel.
> It took me a moment to see the logic here, but I understand it now.
>

Could be even better to place the error message simply right after the
register_restart_handler().