Re: [PATCH] mfd: dln2: Switch to kvfree_rcu() API

[Uladzislau Rezki]

On Thu, Dec 16, 2021 at 6:02 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> On Wed, 15 Dec 2021, Uladzislau Rezki wrote:
>
> > On Wed, Dec 15, 2021 at 12:18:41PM +0100, Uladzislau Rezki (Sony) wrote:
> > > Instead of invoking a synchronize_rcu() to free a pointer
> > > after a grace period we can directly make use of new API
> > > that does the same but in more efficient way.
> > >
> > > TO: Lee Jones <lee.jones@xxxxxxxxxx>
> > > TO: Mike Marciniszyn <mike.marciniszyn@xxxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
> > > ---
> > >  drivers/mfd/dln2.c | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/mfd/dln2.c b/drivers/mfd/dln2.c
> > > index 852129ea0766..365e3e77cac4 100644
> > > --- a/drivers/mfd/dln2.c
> > > +++ b/drivers/mfd/dln2.c
> > > @@ -179,10 +179,8 @@ void dln2_unregister_event_cb(struct platform_device *pdev, u16 id)
> > >
> > >     spin_unlock_irqrestore(&dln2->event_cb_lock, flags);
> > >
> > > -   if (found) {
> > > -           synchronize_rcu();
> > > -           kfree(i);
> > > -   }
> > > +   if (found)
> > > +           kvfree_rcu(i);
> > >  }
> > >  EXPORT_SYMBOL(dln2_unregister_event_cb);
> > >
> > + Lee Jones <lee.jones@xxxxxxxxxx>
> > + Mike Marciniszyn <mike.marciniszyn@xxxxxxxxxxxxxxxxxxxx>
>
> I can't do anything with this.
>
> Send it properly please.
>
I got. Will do.

Thanks!

-- 
Uladzislau Rezki