Re: [PATCH v2 1/2] mtd: spi-nor: micron-st: make mt25ql02g/mt25qu02g match more specific, add 4B opcodes

[Pratyush Yadav]

On 17/12/21 11:07AM, Matthias Schiffer wrote:
> On Fri, 2021-12-17 at 00:22 +0530, Pratyush Yadav wrote:
> > Hi Matthias,
> > 
> > On 07/10/21 02:08PM, Matthias Schiffer wrote:
> > > Change the mt25ql02g/mt25qu02g entries to include
> > > SPI_NOR_4B_OPCODES. In
> > > addition, the SPI_NOR_DUAL_READ flag is added to mt25ql02g; this
> > > seems
> > > to have been an accidental omission, as mt25ql02g and mt25qu02g
> > > should
> > > support the same features.
> > 
> > The way flags are specified are changed a bit. See [0]. Please re-
> > roll 
> > your patch to use the new flag types. If this flash supports SFDP
> > you 
> > should ideally just need to set the sfdp flag to true and the core 
> > should take care of the rest. Test reports with the new changes would
> > be 
> > much appreciated :-)
> 
> Will do. Is there an easy way to check which features the kernel
> detected from the SFDP with the new code?

Hm, I don't think so. I think you would have to add debug prints in the 
driver to know which flags were discovered by SFDP.

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.