[pinchartl-media:gmsl/max9286/bindings 44/45] drivers/media/v4l2-core/v4l2-subdev.c:1595:29: error: no member named 'entity' in 'struct v4l2_subdev'
From: kernel test robot
Date: Fri Dec 17 2021 - 04:13:06 EST
tree: git://linuxtv.org/pinchartl/media.git gmsl/max9286/bindings
head: b551a93fb443867f1a950d6063910639bd303daf
commit: 1bf95761342cbb5585b976194300d58bc6f30000 [44/45] media: subdev: Extend routing validation helper
config: x86_64-randconfig-r015-20211216 (https://download.01.org/0day-ci/archive/20211217/202112171701.AthgRmzn-lkp@xxxxxxxxx/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 9043c3d65b11b442226015acfbf8167684586cfa)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add pinchartl-media git://linuxtv.org/pinchartl/media.git
git fetch --no-tags pinchartl-media gmsl/max9286/bindings
git checkout 1bf95761342cbb5585b976194300d58bc6f30000
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/media/v4l2-core/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/media/v4l2-core/v4l2-subdev.c:1409:10: error: implicit declaration of function '__v4l2_subdev_state_alloc' [-Werror,-Wimplicit-function-declaration]
state = __v4l2_subdev_state_alloc(sd, name, key);
^
drivers/media/v4l2-core/v4l2-subdev.c:1409:8: warning: incompatible integer to pointer conversion assigning to 'struct v4l2_subdev_state *' from 'int' [-Wint-conversion]
state = __v4l2_subdev_state_alloc(sd, name, key);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media/v4l2-core/v4l2-subdev.c:1421:2: error: implicit declaration of function '__v4l2_subdev_state_free' [-Werror,-Wimplicit-function-declaration]
__v4l2_subdev_state_free(sd->active_state);
^
>> drivers/media/v4l2-core/v4l2-subdev.c:1595:29: error: no member named 'entity' in 'struct v4l2_subdev'
remote_pads = kcalloc(sd->entity.num_pads, sizeof(*remote_pads),
~~ ^
drivers/media/v4l2-core/v4l2-subdev.c:1600:23: error: no member named 'entity' in 'struct v4l2_subdev'
for (i = 0; i < sd->entity.num_pads; ++i)
~~ ^
drivers/media/v4l2-core/v4l2-subdev.c:1608:30: error: no member named 'entity' in 'struct v4l2_subdev'
if (route->sink_pad >= sd->entity.num_pads ||
~~ ^
drivers/media/v4l2-core/v4l2-subdev.c:1609:13: error: no member named 'entity' in 'struct v4l2_subdev'
!(sd->entity.pads[route->sink_pad].flags & MEDIA_PAD_FL_SINK)) {
~~ ^
drivers/media/v4l2-core/v4l2-subdev.c:1615:32: error: no member named 'entity' in 'struct v4l2_subdev'
if (route->source_pad >= sd->entity.num_pads ||
~~ ^
drivers/media/v4l2-core/v4l2-subdev.c:1616:13: error: no member named 'entity' in 'struct v4l2_subdev'
!(sd->entity.pads[route->source_pad].flags & MEDIA_PAD_FL_SOURCE)) {
~~ ^
1 warning and 8 errors generated.
vim +1595 drivers/media/v4l2-core/v4l2-subdev.c
1585
1586 int v4l2_subdev_routing_validate(struct v4l2_subdev *sd,
1587 const struct v4l2_subdev_krouting *routing,
1588 enum v4l2_subdev_routing_restriction disallow)
1589 {
1590 u32 *remote_pads = NULL;
1591 unsigned int i, j;
1592 int ret = -EINVAL;
1593
1594 if (disallow & V4L2_SUBDEV_ROUTING_NO_STREAM_MIX) {
> 1595 remote_pads = kcalloc(sd->entity.num_pads, sizeof(*remote_pads),
1596 GFP_KERNEL);
1597 if (!remote_pads)
1598 return -ENOMEM;
1599
1600 for (i = 0; i < sd->entity.num_pads; ++i)
1601 remote_pads[i] = U32_MAX;
1602 }
1603
1604 for (i = 0; i < routing->num_routes; ++i) {
1605 const struct v4l2_subdev_route *route = &routing->routes[i];
1606
1607 /* Validate the sink and source pad numbers. */
1608 if (route->sink_pad >= sd->entity.num_pads ||
1609 !(sd->entity.pads[route->sink_pad].flags & MEDIA_PAD_FL_SINK)) {
1610 dev_dbg(sd->dev, "route %u sink (%u) is not a sink pad\n",
1611 i, route->sink_pad);
1612 goto out;
1613 }
1614
1615 if (route->source_pad >= sd->entity.num_pads ||
1616 !(sd->entity.pads[route->source_pad].flags & MEDIA_PAD_FL_SOURCE)) {
1617 dev_dbg(sd->dev, "route %u source (%u) is not a source pad\n",
1618 i, route->source_pad);
1619 goto out;
1620 }
1621
1622 /*
1623 * V4L2_SUBDEV_ROUTING_NO_STREAM_MIX: Streams on the same pad
1624 * may not be routed to streams on different pads.
1625 */
1626 if (disallow & V4L2_SUBDEV_ROUTING_NO_STREAM_MIX) {
1627 if (remote_pads[route->sink_pad] != U32_MAX &&
1628 remote_pads[route->sink_pad] != route->source_pad) {
1629 dev_dbg(sd->dev,
1630 "route %u attempts to mix %s streams\n",
1631 i, "sink");
1632 goto out;
1633 }
1634
1635 if (remote_pads[route->source_pad] != U32_MAX &&
1636 remote_pads[route->source_pad] != route->sink_pad) {
1637 dev_dbg(sd->dev,
1638 "route %u attempts to mix %s streams\n",
1639 i, "source");
1640 goto out;
1641 }
1642
1643 remote_pads[route->sink_pad] = route->source_pad;
1644 remote_pads[route->source_pad] = route->sink_pad;
1645 }
1646
1647 for (j = i + 1; j < routing->num_routes; ++j) {
1648 const struct v4l2_subdev_route *r = &routing->routes[j];
1649
1650 /*
1651 * V4L2_SUBDEV_ROUTING_NO_1_TO_N: No two routes can
1652 * originate from the same (sink) stream.
1653 */
1654 if ((disallow & V4L2_SUBDEV_ROUTING_NO_1_TO_N) &&
1655 route->sink_pad == r->sink_pad &&
1656 route->sink_stream == r->sink_stream) {
1657 dev_dbg(sd->dev,
1658 "routes %u and %u originate from same sink (%u/%u)\n",
1659 i, j, route->sink_pad,
1660 route->sink_stream);
1661 goto out;
1662 }
1663
1664 /*
1665 * V4L2_SUBDEV_ROUTING_NO_N_TO_1: No two routes can end
1666 * at the same (source) stream.
1667 */
1668 if ((disallow & V4L2_SUBDEV_ROUTING_NO_N_TO_1) &&
1669 route->source_pad == r->source_pad &&
1670 route->source_stream == r->source_stream) {
1671 dev_dbg(sd->dev,
1672 "routes %u and %u end at same source (%u/%u)\n",
1673 i, j, route->source_pad,
1674 route->source_stream);
1675 goto out;
1676 }
1677 }
1678 }
1679
1680 ret = 0;
1681
1682 out:
1683 kfree(remote_pads);
1684 return ret;
1685 }
1686 EXPORT_SYMBOL_GPL(v4l2_subdev_routing_validate);
1687
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx