Re: [PATCH v3] crypto: hisilicon - replace 'smp_processor_id' with the raw version of the macro

[Herbert Xu]

On Mon, Dec 06, 2021 at 06:51:09PM +0800, Kai Ye wrote:
> smp_processor_id() is unsafe if it's used in a preemption-on critical
> section. It will cause the call trace when the preemption-on and sets the
> CONFIG_DEBUG_PREEMPT. So replace 'smp_processor_id' with the raw version of
> the marco in preemptible to avoid the following call trace:

What you wrote here makes zero sense.  If smp_processor_id is
unsafe then the raw version is even more unsafe.

Please provide the actual justification as to why it is *safe*.

Even better, put the justification in the patch as a comment
instead of the changelog.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt