Re: [PATCH v3 1/2] dt-bindings: watchdog: Add bindings doc for Sunplus SP7021

[Rob Herring]

On Wed, Dec 15, 2021 at 06:18:30PM +0800, Xiantao Hu wrote:
> Add bindings documentation for Sunplus SP7021 SoC.
> 
> Signed-off-by: Xiantao Hu <xt.hu@xxxxxxxxxxx>
> ---
> Changes in v3:
>  - removed second reg source. The registers are not used in the driver.

Use by a driver doesn't matter. If they are part of the h/w, put them in 
the binding.

> 
>  .../bindings/watchdog/sunplus,sp7021-wdt.yaml | 45 +++++++++++++++++++
>  MAINTAINERS                                   |  6 +++
>  2 files changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml b/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> new file mode 100644
> index 000000000..033e2f599
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/sunplus,sp7021-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SoCs Watchdog Device Tree Bindings
> +
> +maintainers:
> +  - XianTao Hu <xt.hu@xxxxxxxxxxx>
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    const: sunplus,sp7021-wdt
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - resets
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    watchdog: watchdog@9c000630 {
> +        compatible = "sunplus,sp7021-wdt";
> +        reg = <0x9c000630 0x08>;
> +        clocks = <&clkc 0x24>;
> +        resets = <&rstc 0x14>;
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e0bca0de0..c2ba65155 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17933,6 +17933,12 @@ L:	netdev@xxxxxxxxxxxxxxx
>  S:	Maintained
>  F:	drivers/net/ethernet/dlink/sundance.c
>  
> +SUNPLUS WATCHDOG DRIVER
> +M:	Xiantao Hu <xt.hu@xxxxxxxxxxx>
> +L:	linux-watchdog@xxxxxxxxxxxxxxx
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/watchdog/sunplus,sp7021-wdt.yaml
> +
>  SUPERH
>  M:	Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>
>  M:	Rich Felker <dalias@xxxxxxxx>
> -- 
> 2.33.1
> 
>