Re: [PATCH v9 3/3] bluetooth: mgmt: Fix sizeof in mgmt_device_found()

[Luiz Augusto von Dentz]

Hi Manish,

On Thu, Dec 16, 2021 at 4:50 AM Manish Mandlik <mmandlik@xxxxxxxxxx> wrote:
>
> Use correct sizeof() parameter while allocating skb.
>
> Signed-off-by: Manish Mandlik <mmandlik@xxxxxxxxxx>
> ---
>
> (no changes since v8)
>
> Changes in v8:
> - New patch in the series.
>
>  net/bluetooth/mgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index c65247b5896c..5fd29bd399f1 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -9709,7 +9709,7 @@ void mgmt_device_found(struct hci_dev *hdev, bdaddr_t *bdaddr, u8 link_type,
>
>         /* Allocate skb. The 5 extra bytes are for the potential CoD field */
>         skb = mgmt_alloc_skb(hdev, MGMT_EV_DEVICE_FOUND,
> -                            sizeof(ev) + eir_len + scan_rsp_len + 5);
> +                            sizeof(*ev) + eir_len + scan_rsp_len + 5);
>         if (!skb)
>                 return;
>
> --
> 2.34.1.173.g76aa8bc2d0-goog

There is already a patch addressing this:

https://patchwork.kernel.org/project/bluetooth/patch/20211213212650.2067066-1-luiz.dentz@xxxxxxxxx/

Please use that instead and if that works for you reply adding Tested-by.


-- 
Luiz Augusto von Dentz