Re: [PATCH v3 2/2] arm64: dts: imx8mm: Add support for emtrion emCON-MX8M Mini

[Fabio Estevam]

Hi Reinhold,

On Thu, Dec 16, 2021 at 1:59 PM <reinhold.mueller@xxxxxxxxxxx> wrote:

> +       reserved-memory {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               ranges;
> +
> +               rpmsg_reserved: rpmsg@b8000000 {
> +                       no-map;
> +                       reg = <0 0xb8000000 0 0x400000>;
> +               };
> +
> +               loader_reserved: loader@bb700000 {
> +                       no-map;
> +                       reg = <0 0xbb700000 0x0 0x00100000>;
> +               };
> +
> +               pci_reserved: pci@bb800000 {
> +                       no-map;
> +                       reg = <0 0xbb800000 0x0 0x00200000>;
> +               };
> +
> +               ivshmem2_reserved: ivshmem2@bba00000 {
> +                       no-map;
> +                       reg = <0 0xbba00000 0x0 0x00100000>;
> +               };
> +
> +               ivshmem_reserved: ivshmem@bbb00000 {
> +                       no-map;
> +                       reg = <0 0xbbb00000 0x0 0x00100000>;
> +               };
> +       };

Are these reserved nodes needed with mainline?

Looks like they are remnants from NXP vendor BSP.

> +&fec1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_fec1>;
> +       phy-mode = "rgmii-id";
> +       phy-reset-gpios = <&gpio1 9 0>;

phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;

Actually, phy-reset-gpios is considered deprecated.

You could also add an mdio node as fec child and:
add reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>; there.