Re: [PATCH] usb: ohci-spear: Remove direct access to platform_device resource list

From: Alan Stern
Date: Thu Dec 16 2021 - 11:10:48 EST


On Wed, Dec 15, 2021 at 04:55:09PM -0600, Rob Herring wrote:
> The memory resource is already retrieved with platform_get_resource(), so
> let's use it instead of assuming it is the first resource in the array.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

> drivers/usb/host/ohci-spear.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ohci-spear.c b/drivers/usb/host/ohci-spear.c
> index b4cd9e6c72fd..9b81f420656d 100644
> --- a/drivers/usb/host/ohci-spear.c
> +++ b/drivers/usb/host/ohci-spear.c
> @@ -76,7 +76,7 @@ static int spear_ohci_hcd_drv_probe(struct platform_device *pdev)
> goto err_put_hcd;
> }
>
> - hcd->rsrc_start = pdev->resource[0].start;
> + hcd->rsrc_start = res->start;
> hcd->rsrc_len = resource_size(res);
>
> sohci_p = to_spear_ohci(hcd);
> --
> 2.32.0
>