Re: [PATCH] rcu/nocb: clean up some inconsistent indenting

[Paul E. McKenney]

On Thu, Dec 16, 2021 at 05:10:57PM +0800, Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
> 
> kernel/rcu/tree_nocb.h:1262 rcu_spawn_cpu_nocb_kthread() warn:
> inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>

Good catch, but kernel test robot beat you to it:

7512661668d7 ("rcu/nocb: Handle concurrent nocb kthreads creation")

						Thanx, Paul

> ---
>  kernel/rcu/tree_nocb.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h
> index dd4753219dca..936badfffcee 100644
> --- a/kernel/rcu/tree_nocb.h
> +++ b/kernel/rcu/tree_nocb.h
> @@ -1259,7 +1259,8 @@ static void rcu_spawn_cpu_nocb_kthread(int cpu)
>  		}
>  		WRITE_ONCE(rdp_gp->nocb_gp_kthread, t);
>  	}
> -	 mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex);
> +
> +	mutex_unlock(&rdp_gp->nocb_gp_kthread_mutex);
>  
>  	/* Spawn the kthread for this CPU. */
>  	t = kthread_run(rcu_nocb_cb_kthread, rdp,
> -- 
> 2.20.1.7.g153144c
>