Re: [PATCH 0/2] Fix RGB status LED and keyboard backlight LEDs on Nokia N900

From: Merlijn Wajer
Date: Thu Dec 16 2021 - 06:45:51 EST


Hi Pavel,

On 15/12/2021 21:32, Pavel Machek wrote:
> Hi!
>
>> The RGB status LED and keyboard backlight LEDs were broken on the Nokia N900
>> since the conversion to gpiod descriptors and additionally later on with the
>> addition of multi color support. There was at least one attempt merged to fix
>> the lp5523 driver since the gpiod conversion, but it doesn't honour the device
>> tree, which in the case of the Nokia N900 means that the fix doesn't work.
>>
>> In this series are two patches fix the problems:
>>
>> * One addresses the gpiod change in the device tree as well as the multi
>> color support in the device tree;
>> * The other patch fixes the previous attempt at fixing the driver to honour
>> the device tree;
>>
>> Please let me know if anything seems off, and I'll be glad to make any
>> recommended changes, thanks!
>
> Thank you, I took the series. But if it changes the names in
> /sys/class/leds, we want to do something else.

Thanks -- just for the record (I already replied to the other email) -
the names do not change based on my testing.

Regards,
Merlijn