Re: [PATCH] mm/page_alloc: Modify the comment section for alloc_contig_pages()

From: David Hildenbrand
Date: Thu Dec 16 2021 - 05:59:43 EST


On 15.12.21 06:17, Anshuman Khandual wrote:
> Just clarify, that the alloc_contig_pages() allocated range will always be
> aligned to the requested nr_pages.
>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> ---
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index c5952749ad40..0d74ea524dd4 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -9214,8 +9214,8 @@ static bool zone_spans_last_pfn(const struct zone *zone,
> * for allocation requests which can not be fulfilled with the buddy allocator.
> *
> * The allocated memory is always aligned to a page boundary. If nr_pages is a
> - * power of two then the alignment is guaranteed to be to the given nr_pages
> - * (e.g. 1GB request would be aligned to 1GB).
> + * power of two, then allocated range is also guaranteed to be aligned to same
> + * nr_pages (e.g. 1GB request would be aligned to 1GB).
> *
> * Allocated pages can be freed with free_contig_range() or by manually calling
> * __free_page() on each allocated page.
>

To me new vs. old express exactly the same. But it might be an
improvement so I won't object :)

--
Thanks,

David / dhildenb