Re: [PATCH 16/19] kvm: x86: Introduce KVM_{G|S}ET_XSAVE2 ioctl

From: Paolo Bonzini
Date: Thu Dec 16 2021 - 05:28:08 EST


On 12/16/21 09:25, Wang, Wei W wrote:
It's still easier to return the full size of the buffer from KVM_CHECK_EXTENSION(KVM_CAP_XSAVE2). It makes the userspace code
a bit easier.

OK. For the "full size" returned to userspace, would you prefer to
directly use the value retrieved from guest CPUID(0xd), or get it
from guest_fpu (i.e. fpstate->user_size)? (retrieved from CPUID will
be the max size and should work fine as well)

It is okay to reflect only the bits that were enabled in prctl, but please document it in api.rst as well.

Paolo