Re: [PATCH v2] xen-blkfront: Use the bitmap API when applicable

[Christophe JAILLET]

Le 14/12/2021 à 12:08, Roger Pau Monné a écrit :
> On Tue, Dec 14, 2021 at 11:59:39AM +0100, Roger Pau Monné wrote:
> > On Thu, Dec 02, 2021 at 09:16:04PM +0100, Christophe JAILLET wrote:
> > > Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some
> > > open-coded arithmetic in allocator arguments.
> > >
> > > Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> > > consistency.
> > >
> > > Use 'bitmap_copy()' to avoid an explicit 'memcpy()'
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> >
> > Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Oh, I see there's been further discussion on this to avoid relying
> implicitly on the size of the bitmap being rounded to the size of an
> unsigned long. I think a new version is expected then?
>
> Thanks, Roger.

Yes, I'll send a patch in order to add a 'bitmap_size()'
I'll update this patch when/if it is merged.

You can drop it for now.

CJ