Re: [PATCH v4 04/23] PCI/P2PDMA: Expose pci_p2pdma_map_type()

From: Chaitanya Kulkarni
Date: Mon Dec 13 2021 - 17:05:33 EST


On 11/17/21 1:53 PM, Logan Gunthorpe wrote:
> pci_p2pdma_map_type() will be needed by the dma-iommu map_sg
> implementation because it will need to determine the mapping type
> ahead of actually doing the mapping to create the actual IOMMU mapping.
>
> Prototypes for this helper are added to dma-map-ops.h as they are only
> useful to dma map implementations and don't need to pollute the public
> pci-p2pdma header
>
> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
> ---

The documentation looks much better from reviewer point of view.

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>