Re: [PATCH v2 0/5] acpi: Store _PLD information and convert users

From: Andy Shevchenko
Date: Mon Dec 13 2021 - 07:11:10 EST


On Mon, Dec 13, 2021 at 01:32:38PM +0300, Heikki Krogerus wrote:
> Hi,
>
> I'm now using the helpers device_match_acpi_dev() and
> device_match_fwnode() like Andy suggested. No other changes.

FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> The original cover letter:
>
> This removes the need for the drivers to always separately evaluate
> the _PLD. With the USB Type-C connector and USB port mapping this
> allows us to start using the component framework and remove the custom
> APIs.
>
> So far the only users of the _PLD information have been the USB
> drivers, but it seems it will be used also at least in some camera
> drivers later. These nevertheless touch mostly USB drivers.
>
> Rafael, is it still OK if Greg takes these?
>
> Prashant, can you test these?
>
> thanks,
>
>
> Heikki Krogerus (5):
> acpi: Store the Physical Location of Device (_PLD) information
> usb: Use the cached ACPI _PLD entry
> usb: Link the ports to the connectors they are attached to
> usb: typec: port-mapper: Convert to the component framework
> usb: Remove usb_for_each_port()
>
> Documentation/ABI/testing/sysfs-bus-usb | 9 +
> drivers/acpi/scan.c | 79 +++++++
> drivers/usb/core/port.c | 32 +++
> drivers/usb/core/usb-acpi.c | 17 +-
> drivers/usb/core/usb.c | 46 ----
> drivers/usb/typec/Makefile | 3 +-
> drivers/usb/typec/class.c | 2 -
> drivers/usb/typec/class.h | 10 +-
> drivers/usb/typec/port-mapper.c | 280 +++---------------------
> include/acpi/acpi_bus.h | 14 ++
> include/linux/usb.h | 9 -
> include/linux/usb/typec.h | 12 -
> 12 files changed, 184 insertions(+), 329 deletions(-)
>
> --
> 2.33.0
>

--
With Best Regards,
Andy Shevchenko