Re: [PATCH] ALSA: hda/realtek: Amp init fixup for HP ZBook 15 G6

[Takashi Iwai]

On Fri, 10 Dec 2021 20:26:12 +0100,
Bradley Scott wrote:
> 
> HP ZBook 15 G6 (SSID 103c:860f) needs the same speaker amplifier
> initialization as used on several other HP laptops using ALC285.
> 
> This commit also adds a new "alc285-hp-amp-init" model that can be used
> to apply this same amp init fixup to other devices by passing
> "hda_model=alc285-hp-amp-init" to the snd-sof-intel-hda-common module or
> "model=alc285-hp-amp-init" to the snd-hda-intel module, depending on
> which is being used.
> 
> Signed-off-by: Bradley Scott <Bradley.Scott@xxxxxxxxx>

Thanks for the patch.  Unfortunately, somehow your MUA broke the tabs
with spaces and the patch wasn't cleanly applicable.

Also, I prefer splitting the changes to two, the addition of a quirk
entry and the addition to the model string.  Then old stable kernels
have more chance to pick up.

Could you try to resubmit?  In the worst case, I can take the
attachments, too.


Takashi