Re: [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace
From: Greg Kroah-Hartman
Date: Fri Dec 10 2021 - 11:01:46 EST
On Fri, Dec 10, 2021 at 03:48:05PM +0000, David Brazdil wrote:
> In your first email you also mentioned removing the check in dice_probe()
> that only allows a single instance. On a second thought, I think it's
> simpler to keep it there for now, even if the memory is dynamically
> allocated, which I agree makes the code cleaner.
I don't remember what check you are talking about at all, sorry.
Remember some of us review hundreds of patches each week :(
> The reason being that if we allowed multiple instances, we'd also need
> some static unique identifier that ties the cdev filename to the DT entry,
> same as /dev/disk/by-uuid/. Just adding an index number to the misc
> device nodename based on DT probe order sounds very fragile, and
> anything more sophisticated sounds like too much trouble for something
> we don't have a clear use case for right now.
Just add a number to the device node name like every other device in the
system has. Nothing new or special here, right?
thanks,
greg k-h