Re: [PATCH core-next] net/core: remove unneeded variable

[Jakub Kicinski]

On Fri, 10 Dec 2021 02:20:12 +0000 cgel.zte@xxxxxxxxx wrote:
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
> 
> Return status directly from function called.
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> ---
>  net/core/lwtunnel.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
> index 2820aca2173a..c34248e358ac 100644
> --- a/net/core/lwtunnel.c
> +++ b/net/core/lwtunnel.c
> @@ -63,11 +63,7 @@ static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type)
>  
>  struct lwtunnel_state *lwtunnel_state_alloc(int encap_len)
>  {
> -	struct lwtunnel_state *lws;
> -
> -	lws = kzalloc(sizeof(*lws) + encap_len, GFP_ATOMIC);
> -
> -	return lws;
> +	return kzalloc(sizeof(*lws) + encap_len, GFP_ATOMIC);
>  }
>  EXPORT_SYMBOL_GPL(lwtunnel_state_alloc);

I don't think any of your "remove unneeded variable" patches are worth
applying, sorry.

This one doesn't even build.