Re: [PATCH v3 5/5] arm: dts: imx8ulz-bsh-smm-m2: Add BSH SMM-M2 IMX6ULZ SystemMaster

[Ariel D'Alessandro]

Hi Fabio,

On 12/8/21 4:26 PM, Fabio Estevam wrote:
> On Wed, Dec 8, 2021 at 4:21 PM Ariel D'Alessandro
> <ariel.dalessandro@xxxxxxxxxxxxx> wrote:
>>
>> From: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>
>>
>> Add DTS of BSH SMM-M2 SystemMaster.
>>
>> This version comes with:
>> - 128 MiB DDR3 RAM
>> - 256 MiB Nand
>> - wifi
>> - bluetooth
>>
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@xxxxxxxxxxxxx>
>> Signed-off-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/Makefile               |   3 +-
>>  arch/arm/boot/dts/imx6ulz-bsh-smm-m2.dts | 146 +++++++++++++++++++++++
> 
> There is a typo in the Subject: it says imx8ulz, but it should be
> imx6ulz instead.

Ah, you're right. Will fix in v4.

> 
>> +/ {
>> +       model = "BSH SMM M2";
>> +       compatible = "bsh,imx6ulz-bsh-smm-m2", "fsl,imx6ull";
> 
> Shouldn't "fsl,imx6ulz" also be added here like it is done in
> imx6ulz-14x14-evk.dts?

Yes, it should. Will fix in v4.

Thanks a lot,
Ariel