[PATCH] libceph, ceph: potential dereference of null pointer

From: Jiasheng Jiang
Date: Wed Dec 08 2021 - 21:51:05 EST


The return value of kzalloc() needs to be checked.
To avoid use of null pointer in case of the failure of alloc.

Fixes: 3d14c5d2b6e1 ("ceph: factor out libceph from Ceph file system")
Signed-off-by: Jiasheng Jiang <jiasheng@xxxxxxxxxxx>
---
net/ceph/osd_client.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/ceph/osd_client.c b/net/ceph/osd_client.c
index ff8624a7c964..3203e8a34370 100644
--- a/net/ceph/osd_client.c
+++ b/net/ceph/osd_client.c
@@ -1234,6 +1234,8 @@ static struct ceph_osd *create_osd(struct ceph_osd_client *osdc, int onum)
WARN_ON(onum == CEPH_HOMELESS_OSD);

osd = kzalloc(sizeof(*osd), GFP_NOIO | __GFP_NOFAIL);
+ if (!osd)
+ return NULL;
osd_init(osd);
osd->o_osdc = osdc;
osd->o_osd = onum;
--
2.25.1