Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

From: Nayna
Date: Wed Dec 08 2021 - 20:51:50 EST



On 11/25/21 13:02, Michal Suchanek wrote:
Hello,

Hi Michael,


This is resend of the KEXEC_SIG patchset.

The first patch is new because it'a a cleanup that does not require any
change to the module verification code.

The second patch is the only one that is intended to change any
functionality.

The rest only deduplicates code but I did not receive any review on that
part so I don't know if it's desirable as implemented.

The first two patches can be applied separately without the rest.

Patch 2 fails to apply on v5.16-rc4. Can you please also include git tree/branch while posting the patches ?

Secondly, I see that you add the powerpc support in Patch 2 and then modify it again in Patch 5 after cleanup. Why not add the support for powerpc after the clean up ? This will reduce some rework and also probably simplify patches.

Thanks & Regards,

     - Nayna