Re: [PATCH][V2] intel_th: remove redundant re-assignment of pointer hubdrv

From: Dan Carpenter
Date: Wed Dec 08 2021 - 05:02:59 EST


On Tue, Dec 07, 2021 at 11:07:09PM +0000, Colin Ian King wrote:
> The pointer hubdrv is being re-assigned the same value as it was
> initialized with only a few lines earlier. The re-assignment is
> redundant and can be removed.
>
> As Dan Carpenter pointed out, the pointer hubdrv is hub - some_offset
> and in this case some_offset is zero. Since hub has already been
> dereferenced hubdrv can't be NULL so the NULL check is redundant
> and can also be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
>
> ---

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter