Re: [PATCH] carl9170: Use the bitmap API when applicable

From: Kalle Valo
Date: Wed Dec 08 2021 - 03:36:12 EST


Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:

> Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some
> open-coded arithmetic in allocator arguments.
>
> Note, that this 'bitmap_zalloc()' divides by BITS_PER_LONG the amount of
> memory allocated.
> The 'roundup()' used to computed the number of needed long should have
> been a DIV_ROUND_UP.
>
>
> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep
> consistency.
>
> Use 'bitmap_zero()' to avoid hand writing it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Acked-by: Christian Lamparter <chunkeey@xxxxxxxxx>
> Signed-off-by: Kalle Valo <quic_kvalo@xxxxxxxxxxx>

Patch applied to ath-next branch of ath.git, thanks.

6273c97296a8 carl9170: Use the bitmap API when applicable

--
https://patchwork.kernel.org/project/linux-wireless/patch/1fe18fb73f71d855043c40c83865ad539f326478.1638396221.git.christophe.jaillet@xxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches