Re: [RFC PATCH 2/9] dt-bindings: arm: amlogic: add X96-AIR bindings

[Rob Herring]

On Tue, Nov 30, 2021 at 06:05:16AM +0000, Christian Hewitt wrote:
> Add board bindings for the Amediatech X96-AIR STB which ships with
> model variants distiguished by Ethernet configuration: models using
> internal 10/100 PHY have a -100 suffix, while models using external
> Gigabit PHY have a -1000 suffix.

Isn't the phy described in DT? Why do you need to describe this 1 
difference at the top level?

> 
> Signed-off-by: Christian Hewitt <christianshewitt@xxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 36081734f720..e9ab0ffe8be7 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -170,6 +170,8 @@ properties:
>        - description: Boards with the Amlogic Meson SM1 S905X3/D3/Y3 SoC
>          items:
>            - enum:
> +              - amediatech,x96-air-100
> +              - amediatech,x96-air-1000
>                - bananapi,bpi-m5
>                - hardkernel,odroid-c4
>                - hardkernel,odroid-hc4
> -- 
> 2.17.1
> 
>