Re: [PATCH 1/3] iwlwifi: fix LED dependencies

[Johannes Berg]

On Tue, 2021-12-07 at 11:16 +0100, Johannes Berg wrote:
> On Tue, 2021-12-07 at 11:14 +0100, Johannes Berg wrote:
> > On Sat, 2021-12-04 at 18:38 +0100, Arnd Bergmann wrote:
> > >  
> > >  config IWLWIFI_LEDS
> > >  	bool
> > > -	depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI
> > > +	depends on LEDS_CLASS=y || LEDS_CLASS=MAC80211
> > > 
> > 
> > Hm. Can we really not have this if LEDS_CLASS=n?
> > 
> 
> Well, umm. That wouldn't make sense for IWLWIFI_LEDS, sorry.
> 
> Might be simpler to express this as "depends on MAC80211_LEDS" which has
> the same condition, and it feels like that makes more sense than
> referencing MAC80211 here?
> 

Hm, maybe not. Sorry for the monologue here - but MAC80211_LEDS is user
selectable, and so I guess that's a different thing.

johannes