Re: Unused local variable load_addr in load_elf_binary()

From: Kees Cook
Date: Mon Dec 06 2021 - 21:05:01 EST


On Mon, Dec 06, 2021 at 04:46:01PM +0100, Lukas Bulwahn wrote:
> Dear Akira-san,
>
> With commit 0c9333606e30 ("fs/binfmt_elf: Fix AT_PHDR for unusual ELF
> files"), you have changed load_elf_binary() in ./fs/binfmt_elf.c in a
> way such that the local variable load_addr in load_elf_binary() is not
> used anymore.

EEk! yeah, this totally broke ELF randomization. this needs to be
entirely reverted.

--
Kees Cook